Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRAVIS_TAG could set canpush without checking all rules #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TRAVIS_TAG could set canpush without checking all rules #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions doctr/travis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,10 +575,9 @@ def determine_push_rights(*, branch_whitelist, TRAVIS_BRANCH,
"""
canpush = True

if TRAVIS_TAG:
if not build_tags:
print("The docs are not pushed on tag builds. To push on future tag builds, use --build-tags")
return build_tags
if TRAVIS_TAG and not build_tags:
print("The docs are not pushed on tag builds. To push on future tag builds, use --build-tags")
canpush = False

if not any([re.compile(x).match(TRAVIS_BRANCH) for x in branch_whitelist]):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is TRAVIS_BRANCH set to when TRAVIS_TAG is true?

print("The docs are only pushed to gh-pages from master. To allow pushing from "
Expand Down