Merge pull request #64 from dragondrop-cloud/feature/pull_out_nlp_scr…

…ipt_II

Integrate cloud-concierge container with remote NLPEngine Endpoint

.github/workflows/nlpengine-cd.yml

@@ -40,8 +40,8 @@ jobs:
 
       - name: 'Deploy cloud function dev'
         if: ${{ github.ref_name == 'dev'}}
-        run: 'gcloud functions deploy nlpengine-endpoint-dev --gen2 --runtime=python311 --region=us-east4 --source=nlpengine/ --entry-point=train_and_predict --trigger-http --allow-unauthenticated --memory=2048MB --timeout=600s --set-env-vars=DRAGONDROP_API_URL=https://api.dev-dragondrop.cloud --max-instances=10'
+        run: 'gcloud functions deploy nlpengine-endpoint-dev --gen2 --runtime=python311 --region=us-east4 --source=nlpengine/ --entry-point=train_and_predict --trigger-http --allow-unauthenticated --memory=4096MB --timeout=600s --set-env-vars=DRAGONDROP_API_URL=https://api.dev-dragondrop.cloud --max-instances=10'
 
       - name: 'Deploy cloud function prod'
         if: ${{ github.ref_name == 'prod'}}
-        run: 'gcloud functions deploy nlpengine-endpoint-prod --gen2 --runtime=python311 --region=us-east4 --source=nlpengine/ --entry-point=train_and_predict --trigger-http --allow-unauthenticated --memory=2048MB --timeout=600s --set-env-vars=DRAGONDROP_API_URL=https://api.dragondrop.cloud'
+        run: 'gcloud functions deploy nlpengine-endpoint-prod --gen2 --runtime=python311 --region=us-east4 --source=nlpengine/ --entry-point=train_and_predict --trigger-http --allow-unauthenticated --memory=4096MB --timeout=600s --set-env-vars=DRAGONDROP_API_URL=https://api.dragondrop.cloud'

main/internal/implementations/dragon_drop/http_dragondrop_oss_methods.go

@@ -7,6 +7,8 @@ import (
 	"fmt"
 	"io"
 	"os"
+
+	log "github.com/sirupsen/logrus"
 )
 
 // AuthorizeJob Checks with DragonDropAPI for valid auth of the current job, for an oss job
@@ -72,29 +74,28 @@ func (c *HTTPDragonDropClient) PostNLPEngine(ctx context.Context) error {
 		fmt.Sprintf("%v", c.config.NLPEndpoint),
 		bytes.NewBuffer(jsonBody),
 	)
-
 	if err != nil {
 		return fmt.Errorf("[post_nlp_engine][error in newRequest]%w", err)
 	}
 
+	log.Info("Sending request to NLP engine...")
 	response, err := c.httpClient.Do(request)
-
 	if err != nil {
 		return fmt.Errorf("[post_nlp_engine] error in http POST request]%w", err)
 	}
 
 	defer response.Body.Close()
-	if response.StatusCode != 200 {
+	if response.StatusCode != 201 {
 		return fmt.Errorf("[post_nlp_engine][was unsuccessful, with the server returning: %v]", response.StatusCode)
 	}
+	log.Info("NLP engine completed successfully.")
 
 	// Read response body into a string
 	body, err := io.ReadAll(response.Body)
 	if err != nil {
 		return fmt.Errorf("[error reading response body]%v", err)
 	}
-	// TODO: remove once done integration testing
-	fmt.Printf("response body: %v", string(body))
+
 	err = os.WriteFile("outputs/new-resources-to-workspace.json", body, 0400)
 	if err != nil {
 		return fmt.Errorf("[error writing new-resources-to-workspace.json]%v", err)

main/internal/implementations/identify_cloud_actors/log_querier.go

@@ -58,7 +58,6 @@ func NewLogQuerier(globalConfig Config, provider terraformValueObjects.Provider)
 	}
 }
 
-// TODO: Update unit tests to include the createtags action
 // determineActionClass determines the classification of an input method, which is either a resource
 // "modification", "creation", "deletion", or "not_classified".
 func determineActionClass(value string) string {

main/internal/implementations/terraform_import_migration_generator/terraform_import.go

@@ -53,7 +53,6 @@ func (i *TerraformImportMigrationGenerator) Execute(ctx context.Context) error {
 		return fmt.Errorf("[terraform_import_migration_generator][error informing resources mapped to import location]%w", err)
 	}
 
-	// TODO: Major refactor needed here
 	resourceImportMapJSON, err := i.convertProviderToResourceImportMapToJSON(resourceImports)
 	if err != nil {
 		return fmt.Errorf("[terraform_import_migration_generator][error converting Provider to resource import]%w", err)