Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR fixes issue #74: language incompatibility in DQ_KinematicController not resetting the stable region flag #111

Merged

Conversation

ffasilva
Copy link
Member

Main instructions

By submitting this pull request, you automatically agree that you have read and accepted the following conditions:

  • Anyone wanting to propose a new modification or introduce new functionality should reach out to the team first, as proposed modifications that do not comply with the library's development philosophy and style, do not follow the library's architecture, do not introduce a clear and general benefit to the library other than to the person who proposed the modification will likely be rejected with no further discussion.
  • Support for DQ Robotics is given voluntarily and it is not the developers' role to educate and/or convince anyone of their vision.
  • Any possible response and its timeliness will be based on the relevance, accuracy, and politeness of a request and the following discussion.
  • You are familiar with the development workflow.
  • Each pull request should contain only individual changes (several changes of the same type are allowed on the same pull request).
  • Refactoring or modifying internal implementation that is working is not allowed unless comprehensively discussed with and approved by @bvadorno and @mmmarinho.

Description of changes

I have modified the reset_stability_counter() method to ensure compatibility with its C++ version. Namely, the flag system_reached_stable_region_ is now reset to false.

Rationale

This pull request fixes issue #74.

@@ -60,7 +60,14 @@
% DQ Robotics website: dqrobotics.github.io
%
% Contributors to this file:
% Bruno Vihena Adorno - [email protected]
% 1. Bruno Vihena Adorno - [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change my email to [email protected].

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emails updated in 43bf811.

@ffasilva ffasilva requested a review from bvadorno August 16, 2024 11:44
@bvadorno bvadorno merged commit 74b5ffc into dqrobotics:master Aug 16, 2024
1 of 2 checks passed
@ffasilva ffasilva deleted the dq-kinematic-controller-stable-region-flag branch August 17, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants