Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect scale for SQL type NUMERIC #2159

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

goerch
Copy link

@goerch goerch commented Nov 8, 2023

Description

When testing with different SQL numeric types like NUMERIC, NUMERIC(14, 2), NUMERIC(14, 4) we noticed that the views always show two decimal places. This fix respects the SQL schema.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59db85d) 79.31% compared to head (f727f2a) 79.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2159   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files          72       72           
  Lines        8974     8970    -4     
=======================================
- Hits         7118     7115    -3     
+ Misses       1856     1855    -1     
Flag Coverage Δ
python 79.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant