Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fully compatible with opentracing #1170

Merged
merged 5 commits into from
Jan 17, 2025
Merged

feat: fully compatible with opentracing #1170

merged 5 commits into from
Jan 17, 2025

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Jan 14, 2025

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq changed the title Feat/otel status feat: compatible with opentracing Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 45.52846% with 67 lines in your changes missing coverage. Please review.

Project coverage is 48.70%. Comparing base (0c6a456) to head (e5e9358).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/core/xtrace/propagation.go 38.37% 38 Missing and 15 partials ⚠️
pkg/server/xecho/middleware.go 50.00% 3 Missing and 1 partial ⚠️
pkg/store/gorm/interceptor.go 0.00% 3 Missing and 1 partial ⚠️
pkg/server/xgrpc/interceptor.go 57.14% 3 Missing ⚠️
pkg/client/rocketmq/interceptor.go 33.33% 2 Missing ⚠️
pkg/client/resty/resty.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
- Coverage   48.80%   48.70%   -0.11%     
==========================================
  Files         235      236       +1     
  Lines       12938    13025      +87     
==========================================
+ Hits         6315     6344      +29     
- Misses       6146     6185      +39     
- Partials      477      496      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sysulq
Copy link
Member Author

sysulq commented Jan 16, 2025

@sysulq sysulq changed the title feat: compatible with opentracing feat: fully compatible with opentracing Jan 16, 2025
@sysulq sysulq merged commit bf199f9 into master Jan 17, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant