Merge pull request #3343 from sharwell/update-compiler

Update Microsoft.Net.Compilers to 3.5.0-beta4-20153-05
dotnet · Mar 4, 2020 · 6ca97fd · 6ca97fd
2 parents 84449ea + ec4ed0d
commit 6ca97fd
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/eng/Versions.props b/eng/Versions.props
@@ -22,7 +22,7 @@
     <!-- Roslyn -->
     <MicrosoftCodeAnalysisVersion>3.0.0</MicrosoftCodeAnalysisVersion>
     <MicrosoftCodeAnalysisForShippedApisVersion>3.5.0-beta2-20056-01</MicrosoftCodeAnalysisForShippedApisVersion>
-    <MicrosoftNetCompilersVersion>3.4.0-beta2-final</MicrosoftNetCompilersVersion>
+    <MicrosoftNetCompilersVersion>3.5.0-beta4-20153-05</MicrosoftNetCompilersVersion>
     <DogfoodAnalyzersVersion>3.0.0-beta2.19529.2+e119d9cf</DogfoodAnalyzersVersion>
     <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>$(DogfoodAnalyzersVersion)</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
     <MicrosoftCodeAnalysisFXCopAnalyersVersion>$(DogfoodAnalyzersVersion)</MicrosoftCodeAnalysisFXCopAnalyersVersion>

diff --git a/src/Utilities/Compiler/Options/AnalyzerOptionsExtensions.cs b/src/Utilities/Compiler/Options/AnalyzerOptionsExtensions.cs
@@ -252,6 +252,7 @@ private static SymbolNamesWithValueOption<TValue> GetSymbolNamesWithValueOption<
             Compilation compilation,
             CancellationToken cancellationToken,
             Func<string, SymbolNamesWithValueOption<TValue>.NameParts>? getTypeAndSuffixFunc = null)
+            where TValue : notnull
         {
             var analyzerConfigOptions = options.GetOrComputeCategorizedAnalyzerConfigOptions(cancellationToken);
             return analyzerConfigOptions.GetOptionValue(optionName, rule, TryParse, defaultValue: SymbolNamesWithValueOption<TValue>.Empty);

diff --git a/src/Utilities/Compiler/Options/SymbolNamesWithValueOption.cs b/src/Utilities/Compiler/Options/SymbolNamesWithValueOption.cs
@@ -11,6 +11,7 @@
 namespace Analyzer.Utilities
 {
     internal sealed class SymbolNamesWithValueOption<TValue> : IEquatable<SymbolNamesWithValueOption<TValue>?>
+        where TValue : notnull
     {
         public static readonly SymbolNamesWithValueOption<TValue> Empty = new SymbolNamesWithValueOption<TValue>();
 
@@ -116,7 +117,7 @@ public bool Contains(ISymbol symbol)
         /// <summary>
         /// Gets the value associated with the specified symbol in the option specification.
         /// </summary>
-        public bool TryGetValue(ISymbol symbol, [NotNullWhen(true)] out TValue value) =>
+        public bool TryGetValue(ISymbol symbol, [MaybeNullWhen(false)] out TValue value) =>
             _symbols.TryGetValue(symbol, out value) || _names.TryGetValue(symbol.Name, out value);
 
         public override bool Equals(object obj) => Equals(obj as SymbolNamesWithValueOption<TValue>);

diff --git a/src/Utilities/FlowAnalysis/FlowAnalysis/Analysis/DisposeAnalysis/DisposeAnalysisHelper.cs b/src/Utilities/FlowAnalysis/FlowAnalysis/Analysis/DisposeAnalysis/DisposeAnalysisHelper.cs
@@ -121,6 +121,7 @@ public bool TryGetOrComputeResult(
                     defaultDisposeOwnershipTransferAtConstructor: defaultDisposeOwnershipTransferAtConstructor);
                 if (disposeAnalysisResult != null)
                 {
+                    RoslynDebug.Assert(pointsToAnalysisResult is object);
                     return true;
                 }
             }