Remove mock APIs used for PC analyzer as we can now use new APIs (#4483)

dotnet · Dec 2, 2020 · 32d97c9 · 32d97c9
1 parent c00d594
commit 32d97c9
Show file tree

Hide file tree

Showing 3 changed files with 497 additions and 999 deletions.
diff --git a/...alyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs b/...alyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
@@ -136,13 +136,9 @@ public override void Initialize(AnalysisContext context)
 
                 var typeName = WellKnownTypeNames.SystemOperatingSystem;
 
-                // TODO: remove 'typeName + "Helper"' after tests able to consume the real new APIs
-                if (!context.Compilation.TryGetOrCreateTypeByMetadataName(typeName + "Helper", out var operatingSystemType))
+                if (!context.Compilation.TryGetOrCreateTypeByMetadataName(typeName, out var operatingSystemType))
                 {
-                    if (!context.Compilation.TryGetOrCreateTypeByMetadataName(typeName, out operatingSystemType))
-                    {
-                        return;
-                    }
+                    return;
                 }
 
                 var osPlatformType = context.Compilation.GetOrCreateTypeByMetadataName(WellKnownTypeNames.SystemRuntimeInteropServicesOSPlatform);