Disable RS1022 by default

dotnet · Jun 22, 2023 · 21a5c52 · 21a5c52
1 parent 99079c7
commit 21a5c52
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/docs/rules/RS1022.md b/docs/rules/RS1022.md
@@ -5,7 +5,7 @@ Diagnostic analyzer types should not use types from Workspaces assemblies. Works
 |Item|Value|
 |-|-|
 |Category|MicrosoftCodeAnalysisCorrectness|
-|Enabled|True|
+|Enabled|False|
 |Severity|Warning|
 |CodeFix|False|
 ---

diff --git a/src/Microsoft.CodeAnalysis.Analyzers/Core/AnalyzerReleases.Unshipped.md b/src/Microsoft.CodeAnalysis.Analyzers/Core/AnalyzerReleases.Unshipped.md
@@ -5,3 +5,9 @@
 Rule ID | Category | Severity | Notes
 --------|----------|----------|-------
 RS1038 | MicrosoftCodeAnalysisCorrectness | Warning | CompilerExtensionStrictApiAnalyzer
+
+### Changed Rules
+
+Rule ID | New Category | New Severity | Old Category | Old Severity | Notes
+--------|--------------|--------------|--------------|--------------|-------
+RS1022 | MicrosoftCodeAnalysisCorrectness | Disabled | MicrosoftCodeAnalysisCorrectness | Warning | DiagnosticAnalyzerApiUsageAnalyzer
diff --git a/...Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DiagnosticAnalyzerAPIUsageAnalyzer.cs b/...Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DiagnosticAnalyzerAPIUsageAnalyzer.cs
@@ -38,7 +38,7 @@ public abstract class DiagnosticAnalyzerApiUsageAnalyzer<TTypeSyntax> : Diagnost
             CreateLocalizableResourceString(nameof(DoNotUseTypesFromAssemblyRuleDirectMessage)),
             DiagnosticCategory.MicrosoftCodeAnalysisCorrectness,
             DiagnosticSeverity.Warning,
-            isEnabledByDefault: true,
+            isEnabledByDefault: false,
             description: s_localizableDescription,
             helpLinkUri: HelpLinkUri,
             customTags: WellKnownDiagnosticTagsExtensions.CompilationEndAndTelemetry);
@@ -49,7 +49,7 @@ public abstract class DiagnosticAnalyzerApiUsageAnalyzer<TTypeSyntax> : Diagnost
             CreateLocalizableResourceString(nameof(DoNotUseTypesFromAssemblyRuleIndirectMessage)),
             DiagnosticCategory.MicrosoftCodeAnalysisCorrectness,
             DiagnosticSeverity.Warning,
-            isEnabledByDefault: true,
+            isEnabledByDefault: false,
             description: s_localizableDescription,
             helpLinkUri: HelpLinkUri,
             customTags: WellKnownDiagnosticTagsExtensions.CompilationEndAndTelemetry);

diff --git a/src/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.md b/src/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.md
@@ -275,7 +275,7 @@ Diagnostic analyzer types should not use types from Workspaces assemblies. Works
 |Item|Value|
 |-|-|
 |Category|MicrosoftCodeAnalysisCorrectness|
-|Enabled|True|
+|Enabled|False|
 |Severity|Warning|
 |CodeFix|False|
 ---

diff --git a/src/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.sarif b/src/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.sarif
@@ -806,7 +806,7 @@
           "helpUri": "https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1022.md",
           "properties": {
             "category": "MicrosoftCodeAnalysisCorrectness",
-            "isEnabledByDefault": true,
+            "isEnabledByDefault": false,
             "typeName": "CSharpDiagnosticAnalyzerApiUsageAnalyzer",
             "languages": [
               "C#"
@@ -1005,7 +1005,7 @@
           "helpUri": "https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1022.md",
           "properties": {
             "category": "MicrosoftCodeAnalysisCorrectness",
-            "isEnabledByDefault": true,
+            "isEnabledByDefault": false,
             "typeName": "BasicDiagnosticAnalyzerApiUsageAnalyzer",
             "languages": [
               "Visual Basic"