Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runner version to macos-13, as setup-python only support >=3.11 on osx 14 #663

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

robtaylor
Copy link
Collaborator

This is a limitation in setup-python, and a quick fix.

I think a better solution would be to use matrix for the os's and then use exclude for unsupported versions and possibly also use poetry environments for the different python versions, though this would be a bigger change to the CI.
Let me know if that would be of interest.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (fe8fc8d) to head (55a1a5e).
Report is 30 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #663   +/-   ##
========================================
  Coverage    96.32%   96.32%           
========================================
  Files           41       41           
  Lines         5218     5218           
  Branches       976      976           
========================================
  Hits          5026     5026           
  Misses         120      120           
  Partials        72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacebrowning jacebrowning merged commit f92c598 into doorstop-dev:develop Sep 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants