Skip to content

Commit

Permalink
Improve testing of noreorder option
Browse files Browse the repository at this point in the history
Signed-off-by: Florian Wühr <[email protected]>
  • Loading branch information
fwuehr1995 committed Jan 30, 2024
1 parent bc32a7a commit 5d3f85a
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions doorstop/cli/tests/test_all.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
REQ_COUNT = 23
ALL_COUNT = 55


class TempTestCase(unittest.TestCase):
"""Base test case class with a temporary directory."""

Expand Down Expand Up @@ -89,7 +88,7 @@ def test_create(self):
self.assertIs(None, main(["create", "_TEMP", self.temp, "-p", "REQ"]))

@patch("subprocess.call", Mock())
def test_create_error_unknwon_parent(self):
def test_create_error_unknown_parent(self):
"""Verify 'doorstop create' returns an error with an unknown parent."""
self.assertRaises(
SystemExit, main, ["create", "_TEMP", self.temp, "-p", "UNKNOWN"]
Expand Down Expand Up @@ -171,9 +170,17 @@ def test_add_specific_level(self):
self.assertIs(None, main(["add", "TUT", "--level", "1.42"]))
self.assertTrue(os.path.isfile(self.path))

def test_add_noreorder(self):
@patch("doorstop.core.document.Document.add_item")
def test_add_noreorder(self, mock_add_item):
"""Verify 'doorstop add' can be called without reordering"""
self.assertIs(None, main(["add", "TUT", "--noreorder"]))
mock_add_item.assert_called_once_with(level=None, defaults=None, name=None, reorder=False)

@patch("doorstop.core.document.Document.add_item")
def test_add_reorder(self, mock_add_item):
"""Verify 'doorstop add' can be called witout --noreorder parameter (automatic reordering)"""
self.assertIs(None, main(["add", "TUT"]))
mock_add_item.assert_called_once_with(level=None, defaults=None, name=None, reorder=True)

def test_add_error(self):
"""Verify 'doorstop add' returns an error with an unknown prefix."""
Expand Down Expand Up @@ -209,7 +216,7 @@ def test_add_no_server(self):
def test_add_custom_server(self, mock_add_item):
"""Verify 'doorstop add' can be called with a custom server."""
self.assertIs(None, main(["add", "TUT", "--server", "1.2.3.4"]))
mock_add_item.assert_called_once_with(defaults=None, level=None, name=None)
mock_add_item.assert_called_once_with(defaults=None, level=None, name=None, reorder=True)

def test_add_force(self):
"""Verify 'doorstop add' can be called with a missing server."""
Expand Down

0 comments on commit 5d3f85a

Please sign in to comment.