Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix starting by and terminated by order #393

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix starting by and terminated by order #393

merged 1 commit into from
Dec 31, 2024

Conversation

jycor
Copy link

@jycor jycor commented Dec 31, 2024

the starting by and terminated by clauses in load data statements can appear in any order and any number of times.

@jycor jycor requested a review from zachmu as a code owner December 31, 2024 06:04
@timsehn timsehn mentioned this pull request Dec 31, 2024
Closed
max-hoffman
max-hoffman approved these changes Dec 31, 2024
View reviewed changes
Copy link

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any number of times? seems a bit weird, so we just pick the right-most values?

@jycor jycor merged commit 18992bb into main Dec 31, 2024
4 checks passed
@jycor jycor deleted the james/load branch December 31, 2024 20:07
@BrewTestBot BrewTestBot mentioned this pull request Jan 2, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @max-hoffman