Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql, Web: compare commits, tags, branches and show diffs #349

Merged
merged 14 commits into from
Jan 22, 2025

Conversation

liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Jan 7, 2025

#292

diff url errors when tags include".". Used commit ids instead of tag names as a workaround in workbench. Need to check if DoltHub has the same issue.

add Diff branches/ commits/ releases buttons to branches/ commits/ releases pages. link to the compare page:
Screenshot 2025-01-16 at 3 31 44 PM

@liuliu-dev liuliu-dev changed the title Graphql, Web: compare two commits and show diffs Graphql, Web: compare commits, tags, branches and show diffs Jan 8, 2025
@liuliu-dev liuliu-dev requested a review from tbantle22 January 13, 2025 18:37
Copy link
Collaborator

@tbantle22 tbantle22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Will review UI one last time too

@@ -50,7 +52,12 @@ function Inner({ commits, ...props }: InnerProps) {
<div className={css.container}>
<div className={css.top}>
<h1 className={css.title}>Commit Log</h1>
<CommitGraphButton params={props.params} />
<div className={css.buttons}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use Button.Group here and remove some of these classes

return (
<FormSelect.Grouped
isLoading={branchLoading || commitLoading || tagLoading}
value={[...branchOptions, ...commitOptions].find(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot tagOptions?

@liuliu-dev liuliu-dev merged commit 08a2bbb into main Jan 22, 2025
1 check passed
@liuliu-dev liuliu-dev deleted the liuliu/commit-comparison branch January 22, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants