-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphql, Web: compare commits, tags, branches and show diffs #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! Will review UI one last time too
@@ -50,7 +52,12 @@ function Inner({ commits, ...props }: InnerProps) { | |||
<div className={css.container}> | |||
<div className={css.top}> | |||
<h1 className={css.title}>Commit Log</h1> | |||
<CommitGraphButton params={props.params} /> | |||
<div className={css.buttons}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use Button.Group
here and remove some of these classes
return ( | ||
<FormSelect.Grouped | ||
isLoading={branchLoading || commitLoading || tagLoading} | ||
value={[...branchOptions, ...commitOptions].find( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot tagOptions
?
#292
diff url errors when tags include
"."
. Used commit ids instead of tag names as a workaround in workbench. Need to check if DoltHub has the same issue.add
Diff branches/ commits/ releases
buttons tobranches/ commits/ releases
pages. link to the compare page: