Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoBackends: Use DXGI 1.6 and D3D11_4 #13322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xphalnos
Copy link

@Xphalnos Xphalnos commented Feb 1, 2025

This allows D3D11 and D3D12 to use DXGI 1.6 and D3D11 to use its latest version (11.4)

@BhaaLseN
Copy link
Member

BhaaLseN commented Feb 1, 2025

I'm curious if this actually builds, since it is pure header changes. Does this need anything else, like a specific version of the Windows SDK? Well, builds worked, so that answers my question.

@@ -3,8 +3,6 @@

#pragma once

#include <d3d11.h>
Copy link
Contributor

@iwubcode iwubcode Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is using references to these headers, so the headers need to stay. We adopt an "include what you use" mentality, you can't rely on the fact this is pulling in D3DBase.h because that file could hypothetically be rewritten in the future to not include those headers.

Please fix all files that had removed header references but actually need them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did what you asked.
I left #include <dxgi.h> removed in D3DSwapChain.h and in D3D12SwapChain.h because it is not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants