Enforce XCB within code #13286
Open
Enforce XCB within code #13286
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me. |
dreamsyntax
approved these changes
Feb 6, 2025
dreamsyntax
reviewed
Feb 6, 2025
| // For more information: https://bugs.dolphin-emu.org/issues/11807 | ||
| const char* current_qt_platform = getenv("QT_QPA_PLATFORM"); | ||
| const bool replace_qt_platform = | ||
| (current_qt_platform && strcasecmp(current_qt_platform, "wayland") == 0); |
There was a problem hiding this comment.
Minor nitpick, but I don't see the point to bother comparing for wayland since with the current configuration we force this env even on x11.
There was a problem hiding this comment.
I preferred not to force a specific value on the user except in the case of the known broken Wayland setup, in case the user explicitly choose other options like minimal, offscreen, VNC, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the declaration of
env QT_QPA_PLATFORM=xcbfrom the desktop file/flatpak args to DolphinQt'sMain.cpp.This is particularly useful for users attempting to launch dolphin from the command line by launching the
dolphin-emuexecutable.