Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to only accept photo taken in real time #402

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

vbarrier
Copy link

Hello,

I have added an option to force use of mobile camera on image field. It use the QRcode on desktop to redirect on mobile (like draw signature).

@vbarrier
Copy link
Author

vbarrier commented Jan 3, 2025

Hello @AlexBTurchyn do you accept pull requests?

@omohokcoj
Copy link
Contributor

@vbarrier thanks for the PR, could you please describe a bit more about the purpose of this PR and the problem is solves?

@vbarrier
Copy link
Author

vbarrier commented Jan 4, 2025

@vbarrier thanks for the PR, could you please describe a bit more about the purpose of this PR and the problem is solves?

Sometimes, you really want the user to take a picture and not use an already taken picture like a check-in / check-out report.

@ZelphirKaltstahl
Copy link

Is this even a solvable problem or one that docuseal should solve?

In theory the browser could be made to fake taking a picture in real time and still give you an already existing picture. I don't think there is a way for a web app to know, if the user does not want it to know.

Perhaps this is a problem, that should be solved on another layer than docuseal itself.

@vbarrier
Copy link
Author

vbarrier commented Jan 5, 2025

It's a kind of validation like on the input fields.. And It's an quick and easy solution to handle it. There will be always ways to bypass but not for 99% of the users.

th PR also include the ability to redirect to a phone using a QRcode like you made with the signature.

It could be use by airbnb, car owners or any owners of rental stuff when they want to get pictures and signatures.

@vbarrier
Copy link
Author

vbarrier commented Jan 5, 2025

Is this even a solvable problem or one that docuseal should solve?

In theory the browser could be made to fake taking a picture in real time and still give you an already existing picture. I don't think there is a way for a web app to know, if the user does not want it to know.

Perhaps this is a problem, that should be solved on another layer than docuseal itself.

btw, you should give it a try :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants