blockchain: drop hash param from newBlockNode()

newBlockNode can produce it itself from the passed blockheader.

blockchain/accept.go

@@ -268,7 +268,7 @@ func (b *BlockChain) maybeAcceptBlock(block *dcrutil.Block,
 	// Create a new block node for the block and add it to the in-memory
 	// block chain (could be either a side chain or the main chain).
 	blockHeader := &block.MsgBlock().Header
-	newNode := newBlockNode(blockHeader, block.Hash(), blockHeight,
+	newNode := newBlockNode(blockHeader, blockHeight,
 		ticketsSpentInBlock(block), ticketsRevokedInBlock(block),
 		voteBitsInBlock(block))
 	if prevNode != nil {

blockchain/chain.go

@@ -108,12 +108,12 @@ type blockNode struct {
 // completely disconnected from the chain and the workSum value is just the work
 // for the passed block.  The work sum is updated accordingly when the node is
 // inserted into a chain.
-func newBlockNode(blockHeader *wire.BlockHeader, blockHash *chainhash.Hash, height int64, ticketsSpent []chainhash.Hash, ticketsRevoked []chainhash.Hash, votes []VoteVersionTuple) *blockNode {
+func newBlockNode(blockHeader *wire.BlockHeader, height int64, ticketsSpent []chainhash.Hash, ticketsRevoked []chainhash.Hash, votes []VoteVersionTuple) *blockNode {
 	// Make a copy of the hash so the node doesn't keep a reference to part
 	// of the full block/block header preventing it from being garbage
 	// collected.
 	node := blockNode{
-		hash:           *blockHash,
+		hash:           blockHeader.BlockHash(),
 		workSum:        CalcWork(blockHeader.Bits),
 		height:         height,
 		header:         *blockHeader,
@@ -618,7 +618,7 @@ func (b *BlockChain) loadBlockNode(dbTx database.Tx, hash *chainhash.Hash) (*blo
 	}
 
 	blockHeader := block.MsgBlock().Header
-	node := newBlockNode(&blockHeader, hash, int64(blockHeader.Height),
+	node := newBlockNode(&blockHeader, int64(blockHeader.Height),
 		ticketsSpentInBlock(block), ticketsRevokedInBlock(block),
 		voteBitsInBlock(block))
 	node.inMainChain = true

blockchain/chainio.go

@@ -1321,7 +1321,7 @@ func (b *BlockChain) createChainState() error {
 	// Create a new node from the genesis block and set it as the best node.
 	genesisBlock := dcrutil.NewBlock(b.chainParams.GenesisBlock)
 	header := &genesisBlock.MsgBlock().Header
-	node := newBlockNode(header, genesisBlock.Hash(), 0, nil, nil, nil)
+	node := newBlockNode(header, 0, nil, nil, nil)
 	node.inMainChain = true
 	b.bestNode = node
 
@@ -1483,7 +1483,7 @@ func (b *BlockChain) initChainState() error {
 		// nodes will be loaded on demand as needed.
 		blk := dcrutil.NewBlock(&block)
 		header := &block.Header
-		node := newBlockNode(header, &state.hash, int64(state.height),
+		node := newBlockNode(header, int64(state.height),
 			ticketsSpentInBlock(blk), ticketsRevokedInBlock(blk),
 			voteBitsInBlock(blk))
 		node.inMainChain = true

blockchain/difficulty_test.go

@@ -429,8 +429,7 @@ nextTest:
 					FreshStake: ticketInfo.newTickets,
 					PoolSize:   poolSize,
 				}
-				hash := header.BlockHash()
-				node := newBlockNode(header, &hash,
+				node := newBlockNode(header,
 					int64(nextHeight), nil, nil, nil)
 				node.parent = bc.bestNode
 
@@ -733,8 +732,7 @@ nextTest:
 					FreshStake: ticketInfo.newTickets,
 					PoolSize:   poolSize,
 				}
-				hash := header.BlockHash()
-				node := newBlockNode(header, &hash,
+				node := newBlockNode(header,
 					int64(nextHeight), nil, nil, nil)
 				node.parent = bc.bestNode
 

blockchain/internal_test.go

@@ -49,6 +49,6 @@ func (b *BlockChain) TstCheckBlockHeaderContext(header *wire.BlockHeader, prevNo
 
 // TstNewBlockNode makes the internal newBlockNode function available to the
 // test package.
-func TstNewBlockNode(blockHeader *wire.BlockHeader, blockHash *chainhash.Hash, height int64, ticketsSpent []chainhash.Hash, ticketsRevoked []chainhash.Hash, voteBits []VoteVersionTuple) *blockNode {
-	return newBlockNode(blockHeader, blockHash, height, ticketsSpent, ticketsRevoked, voteBits)
+func TstNewBlockNode(blockHeader *wire.BlockHeader, height int64, ticketsSpent []chainhash.Hash, ticketsRevoked []chainhash.Hash, voteBits []VoteVersionTuple) *blockNode {
+	return newBlockNode(blockHeader, height, ticketsSpent, ticketsRevoked, voteBits)
 }

blockchain/stakeversion_test.go

@@ -35,7 +35,7 @@ func genesisBlockNode(params *chaincfg.Params) *blockNode {
 	// Create a new node from the genesis block.
 	genesisBlock := dcrutil.NewBlock(params.GenesisBlock)
 	header := &genesisBlock.MsgBlock().Header
-	node := newBlockNode(header, genesisBlock.Hash(), 0, nil, nil, nil)
+	node := newBlockNode(header, 0, nil, nil, nil)
 	node.inMainChain = true
 
 	return node
@@ -125,8 +125,7 @@ func newFakeNode(blockVersion int32, height int64, currentNode *blockNode) *bloc
 		Height:  uint32(height),
 		Nonce:   0,
 	}
-	hash := header.BlockHash()
-	node := newBlockNode(header, &hash, 0, nil, nil, nil)
+	node := newBlockNode(header, 0, nil, nil, nil)
 	node.height = height
 	node.parent = currentNode
 
@@ -440,8 +439,7 @@ func TestCalcStakeVersionByNode(t *testing.T) {
 				Height:  uint32(i),
 				Nonce:   uint32(0),
 			}
-			hash := header.BlockHash()
-			node := newBlockNode(header, &hash, 0, nil, nil, nil)
+			node := newBlockNode(header, 0, nil, nil, nil)
 			node.height = i
 			node.parent = currentNode
 
@@ -824,8 +822,7 @@ func TestIsStakeMajorityVersion(t *testing.T) {
 				Nonce:        uint32(0),
 				StakeVersion: test.startStakeVersion,
 			}
-			hash := header.BlockHash()
-			node := newBlockNode(header, &hash, 0, nil, nil, nil)
+			node := newBlockNode(header, 0, nil, nil, nil)
 			node.height = i
 			node.parent = currentNode
 
@@ -912,8 +909,7 @@ func TestLarge(t *testing.T) {
 				Nonce:        uint32(0),
 				StakeVersion: test.startStakeVersion,
 			}
-			hash := header.BlockHash()
-			node := newBlockNode(header, &hash, 0,
+			node := newBlockNode(header, 0,
 				[]chainhash.Hash{}, []chainhash.Hash{},
 				[]VoteVersionTuple{})
 			node.height = i

blockchain/validate.go

@@ -2506,7 +2506,7 @@ func (b *BlockChain) CheckConnectBlock(block *dcrutil.Block) error {
 		return ruleError(ErrMissingParent, err.Error())
 	}
 
-	newNode := newBlockNode(&block.MsgBlock().Header, block.Hash(),
+	newNode := newBlockNode(&block.MsgBlock().Header,
 		block.Height(), ticketsSpentInBlock(block),
 		ticketsRevokedInBlock(block),
 		voteBitsInBlock(block))

blockchain/validate_test.go

@@ -2015,7 +2015,7 @@ func TestCheckBlockHeaderContext(t *testing.T) {
 	// Test failing checkBlockHeaderContext when calcNextRequiredDifficulty
 	// fails.
 	block := dcrutil.NewBlock(&badBlock)
-	newNode := blockchain.TstNewBlockNode(&block.MsgBlock().Header, block.Hash(),
+	newNode := blockchain.TstNewBlockNode(&block.MsgBlock().Header,
 		block.Height(), nil, nil, nil)
 	err = chain.TstCheckBlockHeaderContext(&block.MsgBlock().Header, newNode, blockchain.BFNone)
 	if err == nil {

blockchain/votebits_test.go

@@ -177,7 +177,7 @@ func TestNoQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -214,7 +214,7 @@ func TestNoQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -260,7 +260,7 @@ func TestNoQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -312,7 +312,7 @@ func TestNoQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -374,7 +374,7 @@ func TestNoQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -447,7 +447,7 @@ func TestYesQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -484,7 +484,7 @@ func TestYesQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -530,7 +530,7 @@ func TestYesQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -582,7 +582,7 @@ func TestYesQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -644,7 +644,7 @@ func TestYesQuorum(t *testing.T) {
 			Timestamp:    currentTimestamp,
 		}
 		hash := header.BlockHash()
-		node := newBlockNode(header, &hash, 0, nil, nil, nil)
+		node := newBlockNode(header, 0, nil, nil, nil)
 		node.height = int64(currentHeight)
 		node.parent = currentNode
 
@@ -1849,7 +1849,7 @@ func TestVoting(t *testing.T) {
 					Timestamp:    currentTimestamp,
 				}
 				hash := header.BlockHash()
-				node := newBlockNode(header, &hash, 0, nil, nil,
+				node := newBlockNode(header, 0, nil, nil,
 					nil)
 				node.height = int64(currentHeight)
 				node.parent = currentNode
@@ -2115,7 +2115,7 @@ func TestParallelVoting(t *testing.T) {
 					Timestamp:    currentTimestamp,
 				}
 				hash := header.BlockHash()
-				node := newBlockNode(header, &hash, 0, nil, nil,
+				node := newBlockNode(header, 0, nil, nil,
 					nil)
 				node.height = int64(currentHeight)
 				node.parent = currentNode