fix/recover from webhook goroutines (#1858)

* handle crashes in goroutine events * include stacktrace in errors
diggerhq · Dec 17, 2024 · 3965287 · 3965287
1 parent 6b2ee65
commit 3965287
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/backend/controllers/github.go b/backend/controllers/github.go
@@ -26,6 +26,7 @@ import (
 	"os"
 	"path"
 	"reflect"
+	"runtime/debug"
 	"slices"
 	"strconv"
 	"strings"
@@ -312,6 +313,10 @@ func handlePullRequestEvent(gh utils.GithubClientProvider, payload *github.PullR
 	defer func() {
 		if r := recover(); r != nil {
 			log.Printf("Recovered from panic in handlePullRequestEvent handler: %v", r)
+			log.Printf("\n=== PANIC RECOVERED ===\n")
+			log.Printf("Error: %v\n", r)
+			log.Printf("Stack Trace:\n%s", string(debug.Stack()))
+			log.Printf("=== END PANIC ===\n")
 		}
 	}()
 
@@ -693,6 +698,10 @@ func handleIssueCommentEvent(gh utils.GithubClientProvider, payload *github.Issu
 	defer func() {
 		if r := recover(); r != nil {
 			log.Printf("Recovered from panic in handleIssueCommentEvent handler: %v", r)
+			log.Printf("\n=== PANIC RECOVERED ===\n")
+			log.Printf("Error: %v\n", r)
+			log.Printf("Stack Trace:\n%s", string(debug.Stack()))
+			log.Printf("=== END PANIC ===\n")
 		}
 	}()