preserve capitalization in parent_controller_class_name #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this just now -- my admin parent controller is actually namespaced, so I passed in `--parent_controller=Admin::Base` as my argument, but the generated file has `class Admin::PlansController < Admin::baseController`. By only capitalizing the first character without changing the rest of the string, it preserves the behavior from before, but also fixes it for my use case, or any case where someone deliberately capitalizes the argument to parent_controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this just now -- my admin parent controller is actually namespaced, so I passed in
--parent_controller=Admin::Baseas my argument, but the generated file hasclass Admin::PlansController < Admin::baseController.By only capitalizing the first character without changing the rest of the string, it preserves the behavior from before, but also fixes it for my use case, or any case where someone deliberately capitalizes the argument to parent_controller.