feat(PocketIC): PocketIC certifies time after setting or advancing time #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rs/pocket_ic_server/src/pocket_ic.rs
Outdated
| for subnet in pic.subnets.get_all() { | ||
| subnet.state_machine.set_time(set_time); | ||
| subnet.state_machine.execute_round(); |
There was a problem hiding this comment.
I would favour adding a new endpoint rather than changing this one's semantics. Or are you sure that nobody could want to set the time without immediately executing a round?
There was a problem hiding this comment.
I guess the answer will be: Setting time without certifying it is useless. Is there no way to certify the time without running any message?
There was a problem hiding this comment.
Is there no way to certify the time without running any message?
Great question! There's a way analogously to what StateMachine tests do when, e.g., setting stable memory: 6512401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the endpoint
/instances/<instance_id>/update/set_timecertify state after setting time so that the latest certified state is a state with that time and, e.g., query calls and read state requests are evaluated on a state with the specified time. This also fixes flakiness when using an IC agent shortly after making a PocketIC instance live, but before the live mode executes a round.