Chore: remove ic_api_version field in IC status response

hs/spec_compliance/src/IC/Test/Agent.hs

@@ -249,7 +249,6 @@ makeAgentConfig allow_self_signed_certs ep' subnets httpbin_proto httpbin' to =
       `catch` (\(HUnitFailure _ r) -> putStrLn r >> exitFailure)
 
   putStrLn $ "Spec version tested:  " ++ T.unpack specVersion
-  putStrLn $ "Spec version claimed: " ++ T.unpack (status_api_version s)
 
   return
     AgentConfig
@@ -991,20 +990,17 @@ runGet a b = case Get.runGetOrFail (a <* done) b of
 -- * Status endpoint parsing
 
 data StatusResponse = StatusResponse
-  { status_api_version :: T.Text,
-    status_root_key :: Blob
-  }
+  { status_root_key :: Blob }
 
 statusResponse :: (HasCallStack) => GenR -> IO StatusResponse
 statusResponse =
   asExceptT . record do
-    v <- field text "ic_api_version"
     _ <- optionalField text "impl_source"
     _ <- optionalField text "impl_version"
     _ <- optionalField text "impl_revision"
     pk <- field blob "root_key"
     swallowAllFields -- More fields are explicitly allowed
-    return StatusResponse {status_api_version = v, status_root_key = pk}
+    return StatusResponse { status_root_key = pk}
 
 -- * Interacting with aaaaa-aa (via HTTP)
 

rs/boundary_node/ic_boundary/src/routes.rs

@@ -43,8 +43,6 @@ use crate::{
     snapshot::{Node, RegistrySnapshot},
 };
 
-// TODO which one to use?
-const IC_API_VERSION: &str = "0.18.0";
 pub const ANONYMOUS_PRINCIPAL: Principal = Principal::anonymous();
 const METHOD_HTTP: &str = "http_request";
 
@@ -787,7 +785,6 @@ pub async fn status(
     let health = h.health().await;
 
     let status = HttpStatusResponse {
-        ic_api_version: IC_API_VERSION.to_string(),
         root_key: rk.root_key().await.map(|x| x.into()),
         impl_version: None,
         impl_hash: None,

rs/http_endpoints/public/src/status.rs

@@ -15,10 +15,6 @@ use ic_types::{
 };
 use std::sync::Arc;
 
-// TODO(NET-776)
-// The IC API version reported on status requests.
-const IC_API_VERSION: &str = "0.18.0";
-
 #[derive(Clone)]
 pub(crate) struct StatusService {
     log: ReplicaLogger,
@@ -72,7 +68,6 @@ pub(crate) async fn status(State(state): State<StatusService>) -> Cbor<HttpStatu
     });
 
     let response = HttpStatusResponse {
-        ic_api_version: IC_API_VERSION.to_string(),
         // For test networks, and networks that we still reset
         // rather often, let them indicate the root public key
         // in /api/v2/status, so that agents can fetch them.

rs/types/types/src/messages/http.rs

@@ -757,14 +757,13 @@ pub enum ReplicaHealthStatus {
 #[derive(Clone, Eq, PartialEq, Debug, Deserialize, Serialize)]
 #[serde(rename_all = "snake_case")]
 pub struct HttpStatusResponse {
-    pub ic_api_version: String,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub impl_hash: Option<String>,
     #[serde(skip_serializing_if = "Option::is_none")]
     pub root_key: Option<Blob>,
     #[serde(skip_serializing_if = "Option::is_none")]
     pub impl_version: Option<String>,
     #[serde(skip_serializing_if = "Option::is_none")]
-    pub impl_hash: Option<String>,
-    #[serde(skip_serializing_if = "Option::is_none")]
     pub replica_health_status: Option<ReplicaHealthStatus>,
     #[serde(skip_serializing_if = "Option::is_none")]
     pub certified_height: Option<Height>,

rs/types/types/src/messages/http/tests.rs

@@ -730,15 +730,13 @@ mod cbor_serialization {
     fn encoding_status_without_root_key() {
         assert_cbor_ser_equal(
             &HttpStatusResponse {
-                ic_api_version: "foobar".to_string(),
                 root_key: None,
                 impl_version: Some("0.0".to_string()),
                 impl_hash: None,
                 replica_health_status: Some(ReplicaHealthStatus::Starting),
                 certified_height: None,
             },
             Value::Map(btreemap! {
-                text("ic_api_version") => text("foobar"),
                 text("impl_version") => text("0.0"),
                 text("replica_health_status") => text("starting"),
             }),
@@ -749,15 +747,13 @@ mod cbor_serialization {
     fn encoding_status_with_root_key() {
         assert_cbor_ser_equal(
             &HttpStatusResponse {
-                ic_api_version: "foobar".to_string(),
                 root_key: Some(Blob(vec![1, 2, 3])),
                 impl_version: Some("0.0".to_string()),
                 impl_hash: None,
                 replica_health_status: Some(ReplicaHealthStatus::Healthy),
                 certified_height: None,
             },
             Value::Map(btreemap! {
-                text("ic_api_version") => text("foobar"),
                 text("root_key") => bytes(&[1, 2, 3]),
                 text("impl_version") => text("0.0"),
                 text("replica_health_status") => text("healthy"),
@@ -769,15 +765,13 @@ mod cbor_serialization {
     fn encoding_status_without_health_status() {
         assert_cbor_ser_equal(
             &HttpStatusResponse {
-                ic_api_version: "foobar".to_string(),
                 root_key: Some(Blob(vec![1, 2, 3])),
                 impl_version: Some("0.0".to_string()),
                 impl_hash: None,
                 replica_health_status: None,
                 certified_height: None,
             },
             Value::Map(btreemap! {
-                text("ic_api_version") => text("foobar"),
                 text("root_key") => bytes(&[1, 2, 3]),
                 text("impl_version") => text("0.0"),
             }),
@@ -788,15 +782,13 @@ mod cbor_serialization {
     fn encoding_status_with_certified_height() {
         assert_cbor_ser_equal(
             &HttpStatusResponse {
-                ic_api_version: "foobar".to_string(),
                 root_key: Some(Blob(vec![1, 2, 3])),
                 impl_version: Some("0.0".to_string()),
                 impl_hash: None,
                 replica_health_status: Some(ReplicaHealthStatus::Healthy),
                 certified_height: Some(AmountOf::new(1)),
             },
             Value::Map(btreemap! {
-                text("ic_api_version") => text("foobar"),
                 text("root_key") => bytes(&[1, 2, 3]),
                 text("impl_version") => text("0.0"),
                 text("replica_health_status") => text("healthy"),