test(MR): [MR-638] Include best-effort messages in queues_compatibility_test, stage 1
#3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity_test`, stage 1 Have `queues_compatibility_test` also persist and restore best-effort requests and responses. Unfortunately, the mainnet version that we test against must also have the test module encoding and decoding the same messages (in this case `best_effort_test`) before the test can actually work. So we will require a second stage to actually enable the test once the mainnet version includes this newly added test module.
alin-at-dfinity
requested review from
stiegerc,
derlerd-dfinity and
oggy-dfin
…o Bidirectional when the mainnet version has the best_effort_test module to run against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have
queues_compatibility_testalso persist and restore best-effort requests and responses.Unfortunately, the mainnet version that we test against must also have the test module encoding and decoding the same messages (in this case
best_effort_test) before the test can actually work. So we will require a second stage to actually enable the test once the mainnet version includes this newly added test module.