Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repository): add nip-50 search capability using meilisearch #122

Merged
merged 18 commits into from
Mar 4, 2025

Conversation

SwimmingRieux
Copy link
Member

@SwimmingRieux SwimmingRieux commented Feb 24, 2025

Description

I've implemented a filter using Meilisearch, but the feature is still a work in progress with much left to be done. I’ve opened this draft PR to allow others to review the changes incrementally.

Related Issue

@kehiy kehiy requested a review from ZigBalthazar February 24, 2025 20:54
@kehiy
Copy link
Member

kehiy commented Feb 24, 2025

also, update https://github.com/dezh-tech/immortal/blob/main/documents/NIPs.md and mark 50 as implemented.

@kehiy
Copy link
Member

kehiy commented Feb 28, 2025

for linter issues you can use these:

  1. make fmt
  2. make check

@kehiy
Copy link
Member

kehiy commented Mar 2, 2025

// todo::: should we proxy search to index server and elastic search?

this comment can be removed as well.

@kehiy kehiy marked this pull request as ready for review March 3, 2025 14:27
Copy link
Member

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@kehiy kehiy changed the title feat(WIP): add filter using meilisearch feat(repository): add nip-50 search capability using meilisearch Mar 4, 2025
@kehiy kehiy added the NIPs label Mar 4, 2025
@kehiy kehiy merged commit 8c1239c into dezh-tech:main Mar 4, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nip-50: searching.
3 participants