UPDATE:Transfer Function #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morelucks I think you need to pull from main and sync your implementation with the existing codebase. Good work. |
|
OK thanks
…On Fri, Dec 13, 2024, 1:57 PM CodingCas ***@***.***> wrote:
@morelucks <https://github.com/morelucks> I think you need to pull from
main and sync your implementation with the existing codebase. Good work.
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQ6DYI7SQ7PCNT6UWDLQ4L2FLKSZAVCNFSM6AAAAABTRUH6BWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBRGQYDQMRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@morelucks The code looks good but it seems you did not remove the node modules from the commit history, please do so and also remove the package-lock.json file from the commit history, its an auto generated file. |
|
then please you might have to run forge fmt so that the CI/CD workflow can run successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the transfer function, enabling the transfer of USDT from one user to another using World ID for identity verification. and the test cases