Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding 'DevWorkspace Operator on Developer Sandbox' section to … #1368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ibuziuk
Copy link
Contributor

@ibuziuk ibuziuk commented Jan 7, 2025

docs: Adding 'DevWorkspace Operator on Developer Sandbox' section to …

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@ibuziuk ibuziuk requested a review from dkwon17 as a code owner January 7, 2025 11:29
@ibuziuk ibuziuk requested a review from l0rd January 7, 2025 11:29
README.md Outdated Show resolved Hide resolved
@ibuziuk ibuziuk force-pushed the developer-sandbox branch from 8bbba7c to 72546bd Compare January 9, 2025 13:47
README.md Outdated Show resolved Hide resolved
@ibuziuk
Copy link
Contributor Author

ibuziuk commented Jan 10, 2025

@dkwon17 @l0rd thank you for the review. PR has been updated

Copy link
Collaborator

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, l0rd
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants