This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
Body background now responsive #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devfake#4 Sadly, `background-position-y: ...` won't perfectly fix the gap at the bottom without making a new gap on the top due to the .png being what it is. bg.png could be swapped out for a better image like the one linked below instead, so there's no gaps at all on the bottom of the .png. (Found by googling "book collage covers file:.png", with the Licensed For Reuse tool option enabled) https://upload.wikimedia.org/wikipedia/commons/6/67/Images_used_on_D%C3%A9couvertes_Gallimard_book_covers.jpg It might be a cooler idea to have a div behind the contents that's set to 100vh and 100vw, with <img> tags of .png book covers in the div so you can randomize the bookcovers in the div, and have a finer control over how the books are displayed, like padding, margins, etc. Folder of bookcover .pngs named like "1.png", "2.png", etc, and have a tiny JavaScript script that randomly selects x numbers between 1 and <amount of bookcovers> then add those to the background div.
|
Nevermind this pull request, I just noticed that there's already pulls for this. I don't see a way to undo my pull requests... Hmm. I'm still learning my way around Github. Delete this pull? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4
Sadly,
background-position-y: ...won't perfectly fix the gap at the bottom without making a new gap on the top due to the .png being what it is.bg.png could be swapped out for a better image like the one linked below instead, so there's no gaps at all on the bottom of the .png.
(Found by googling "book collage covers file:.png", with the Licensed For Reuse tool option enabled)
https://upload.wikimedia.org/wikipedia/commons/6/67/Images_used_on_D%C3%A9couvertes_Gallimard_book_covers.jpg
It might be a cooler idea to have a div behind the contents that's set to 100vh and 100vw, with img tags of .png book covers in the div so you can randomize the bookcovers in the div, and have a finer control over how the books are displayed, like padding, margins, etc.
Folder of bookcover .pngs named like "1.png", "2.png", etc, and have a tiny JavaScript script that randomly selects x numbers between 1 and (amount of bookcovers) then add those to the background div.