-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event handling in get_logs
return type. Includes version bump to v0.0.39
#130
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 64.17% 70.16% +5.98%
==========================================
Files 53 49 -4
Lines 2730 2316 -414
==========================================
- Hits 1752 1625 -127
+ Misses 978 691 -287
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
get_logs
return typeget_logs
return type. Includes version bump to v0.0.39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the gains are worth adding an additional opinionated flow. Great work!
Solves #48
This PR adds typed dataclasses as the output of
get_logs
, with well defined types on the output.Important changes:
get_typed_logs
that returns a dataclass. Web3'sget_logs
remains unchanged.