Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invariant checks to fuzz tests #1251

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

sentilesdal
Copy link
Contributor

Adds the following checks:

  1. PV always >= idle
  2. ∆ lp share price should never be more than 0.1%

Part of #1123

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0e8f0c7) 80.98% compared to head (27679c5) 80.90%.

Files Patch % Lines
...ethpy/ethpy/hyperdrive/interface/read_interface.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
- Coverage   80.98%   80.90%   -0.09%     
==========================================
  Files          94       94              
  Lines        5370     5377       +7     
==========================================
+ Hits         4349     4350       +1     
- Misses       1021     1027       +6     
Flag Coverage Δ
unittests 80.90% <14.28%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sentilesdal sentilesdal force-pushed the matt-add-a-couple-invariant-checks branch from 29d1725 to ffac3bd Compare January 17, 2024 18:04
Copy link
Contributor

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@sentilesdal sentilesdal force-pushed the matt-add-a-couple-invariant-checks branch from e25a42d to 27679c5 Compare January 17, 2024 18:16
@sentilesdal sentilesdal merged commit b9b37e6 into main Jan 17, 2024
3 of 4 checks passed
@sentilesdal sentilesdal deleted the matt-add-a-couple-invariant-checks branch January 17, 2024 18:22
@sentilesdal sentilesdal restored the matt-add-a-couple-invariant-checks branch January 26, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants