[stable/k8s-event-logger] Added option to change container name #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-rocket-internet
requested changes
Nov 6, 2023
stable/k8s-event-logger/values.yaml
Outdated
Comment on lines
1
to
2
| image: | ||
| containerName: k8s-event-logger |
There was a problem hiding this comment.
It's not part of the image so I would not put it under here:
Suggested change
| image: | |
| containerName: k8s-event-logger | |
| containerName: k8s-event-logger | |
| image: |
| @@ -37,7 +37,7 @@ spec: | |||
| {{- end }} | |||
| serviceAccountName: {{ include "k8s-event-logger.fullname" . }} | |||
| containers: | |||
| - name: app | |||
| - name: {{ .Values.image.containerName}} | |||
There was a problem hiding this comment.
Suggested change
| - name: {{ .Values.image.containerName}} | |
| - name: {{ .Values.containerName}} |
max-rocket-internet
changed the title
shehbazk
changed the title
max-rocket-internet
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes in deployment.yaml and values.yaml to add an option to change container name. Also set the default to "k8s-event-logger".