Skip to content

Commit

Permalink
Fix wrong shown dealt card
Browse files Browse the repository at this point in the history
  • Loading branch information
ChristophNiehoff committed Sep 13, 2021
1 parent d5e3ce6 commit 3415725
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 17 deletions.
41 changes: 28 additions & 13 deletions src/utils/__tests__/utils.test.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,37 @@
import { getDealtCard, resolvePlayerNames, resolvePlayerName, grammarJoin, getPlayers, getComponentName, getValidMoves, getTypeString, escapeMarkdownText } from '../utils'
import { STARTING_CARD } from '../constants';

it('gets empty card if no card dealt', async () => {
expect(getDealtCard({
dealt: []
})).toBe("");
it('getDealtCard() should get empty card if no card dealt', async () => {
const G = {
dealt: [],
dealtBy: "",
};

const dealtCard = getDealtCard(G);

expect(dealtCard).toBe("");
});

it('gets correct card if a single card is dealt', async () => {
expect(getDealtCard({
dealt: ["A"]
})).toBe("A");
it('getDealtCard() should get correct card if a single card is dealt', async () => {
const G = {
dealt: [null,null,"E3"],
dealtBy: "2",
};

const dealtCard = getDealtCard(G);

expect(dealtCard).toBe("E3");
});

it('gets correct card if a multiple cards are dealt', async () => {
expect(getDealtCard({
dealt: ["A", "B", "C"]
})).toBe("C");
it('getDealtCard() should get correct card if a multiple cards are dealt', async () => {
const G = {
dealt: ["E8","EA","E3"],
dealtBy: "1",
};

const dealtCard = getDealtCard(G);

expect(dealtCard).toBe("EA");
});

it('resolves player names correctly', async () => {
Expand Down Expand Up @@ -118,4 +133,4 @@ it('successfully escapes any malicious markdown text', () => {

expect(escapeMarkdownText('![Uh oh...]("onerror="alert(\'XSS\'))'))
.toBe('\\!\\[Uh oh...\\]\\("onerror="alert\\(\'XSS\'\\)\\)');
})
})
7 changes: 3 additions & 4 deletions src/utils/utils.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { GAMEMODE_CORNUCOPIA } from "./constants";

export function getDealtCard(G) {
let dealtCard = "";
if (G.dealt.length > 0) {
dealtCard = G.dealt[G.dealt.length - 1];
if (G.dealt.length > 0 && G.dealtBy) {
return G.dealt[G.dealtBy];
}
return dealtCard;
return "";
}

export function isGameModeCornucopia(gameMode) {
Expand Down

0 comments on commit 3415725

Please sign in to comment.