Merge pull request #272 from onur-yildirim-infinitusai/adding-stack-t…

…race-for-panics fix: enhance panic error logging in SDK by adding stack trace
deepgram · Feb 13, 2025 · 2a89eda · 2a89eda
2 parents 8b673cd + 7abe92b
commit 2a89eda
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 1 deletion.
diff --git a/pkg/client/common/v1/websocket.go b/pkg/client/common/v1/websocket.go
@@ -13,6 +13,7 @@ import (
 	"net/http"
 	"strings"
 	"time"
+	"runtime/debug"
 
 	"github.com/dvonthenen/websocket"
 	klog "k8s.io/klog/v2"
@@ -271,6 +272,8 @@ func (c *WSClient) listen() {
 	defer func() {
 		if r := recover(); r != nil {
 			klog.V(1).Infof("Panic triggered\n")
+			klog.V(1).Infof("Panic: %v\n", r)
+			klog.V(1).Infof("Stack trace: %s\n", string(debug.Stack()))
 
 			// send error on callback
 			err := ErrFatalPanicRecovered

diff --git a/pkg/client/listen/v1/websocket/client_callback.go b/pkg/client/listen/v1/websocket/client_callback.go
@@ -11,6 +11,7 @@ import (
 	"fmt"
 	"io"
 	"regexp"
+	"runtime/debug"
 	"strings"
 	"time"
 
@@ -246,6 +247,8 @@ func (c *WSCallback) ping() {
 	defer func() {
 		if r := recover(); r != nil {
 			klog.V(1).Infof("Panic triggered\n")
+			klog.V(1).Infof("Panic: %v\n", r)
+			klog.V(1).Infof("Stack trace: %s\n", string(debug.Stack()))
 
 			// send error on callback
 			err := common.ErrFatalPanicRecovered
@@ -289,6 +292,8 @@ func (c *WSCallback) flush() {
 	defer func() {
 		if r := recover(); r != nil {
 			klog.V(1).Infof("Panic triggered\n")
+			klog.V(1).Infof("Panic: %v\n", r)
+			klog.V(1).Infof("Stack trace: %s\n", string(debug.Stack()))
 
 			// send error on callback
 			err := common.ErrFatalPanicRecovered

diff --git a/pkg/client/listen/v1/websocket/client_channel.go b/pkg/client/listen/v1/websocket/client_channel.go
@@ -11,6 +11,7 @@ import (
 	"fmt"
 	"io"
 	"regexp"
+	"runtime/debug"
 	"strings"
 	"time"
 
@@ -246,6 +247,8 @@ func (c *WSChannel) ping() {
 	defer func() {
 		if r := recover(); r != nil {
 			klog.V(1).Infof("Panic triggered\n")
+			klog.V(1).Infof("Panic: %v\n", r)
+			klog.V(1).Infof("Stack trace: %s\n", string(debug.Stack()))
 
 			// send error on callback
 			err := common.ErrFatalPanicRecovered
@@ -289,6 +292,8 @@ func (c *WSChannel) flush() {
 	defer func() {
 		if r := recover(); r != nil {
 			klog.V(1).Infof("Panic triggered\n")
+			klog.V(1).Infof("Panic: %v\n", r)
+			klog.V(1).Infof("Stack trace: %s\n", string(debug.Stack()))
 
 			// send error on callback
 			err := common.ErrFatalPanicRecovered

diff --git a/pkg/client/speak/v1/websocket/client_callback.go b/pkg/client/speak/v1/websocket/client_callback.go
@@ -10,6 +10,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"regexp"
+	"runtime/debug"
 	"strings"
 	"time"
 
@@ -213,6 +214,8 @@ func (c *WSCallback) flush() {
 	defer func() {
 		if r := recover(); r != nil {
 			klog.V(1).Infof("Panic triggered\n")
+			klog.V(1).Infof("Panic: %v\n", r)
+			klog.V(1).Infof("Stack trace: %s\n", string(debug.Stack()))
 
 			// send error on callback
 			err := common.ErrFatalPanicRecovered

diff --git a/pkg/client/speak/v1/websocket/client_channel.go b/pkg/client/speak/v1/websocket/client_channel.go
@@ -10,6 +10,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"regexp"
+	"runtime/debug"
 	"strings"
 	"time"
 
@@ -212,12 +213,14 @@ func (c *WSChannel) flush() {
 	defer func() {
 		if r := recover(); r != nil {
 			klog.V(1).Infof("Panic triggered\n")
+			klog.V(1).Infof("Panic: %v\n", r)
+			klog.V(1).Infof("Stack trace: %s\n", string(debug.Stack()))
 
 			// send error on callback
 			err := common.ErrFatalPanicRecovered
 			sendErr := c.ProcessError(err)
 			if sendErr != nil {
-				klog.V(1).Infof("listen: Fatal socket error. Err: %v\n", sendErr)
+				klog.V(1).Infof("speak: Fatal socket error. Err: %v\n", sendErr)
 			}
 
 			klog.V(6).Infof("speak.flush() LEAVE\n")