Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc genproto module #2453

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Update grpc genproto module #2453

merged 1 commit into from
Jan 13, 2025

Conversation

jrick
Copy link
Member

@jrick jrick commented Jan 2, 2025

For unknown reasons, when dcrwallet is built with a go.work, the solved module graph appears to be different than with GOWORK=off, causing the following build error:

$ go build
../../go/pkg/mod/google.golang.org/[email protected]/status/status.go:35:2: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules:
	google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013 (/home/jrick/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status)
	google.golang.org/genproto/googleapis/rpc v0.0.0-20240604185151-ef581f913117 (/home/jrick/go/pkg/mod/google.golang.org/genproto/googleapis/[email protected]/status)

Updating to a more recent google.golang.org/genproto fixes the workspace build.

For unknown reasons, when dcrwallet is built with a go.work, the solved module
graph appears to be different than with GOWORK=off, causing the following
build error:

$ go build
../../go/pkg/mod/google.golang.org/[email protected]/status/status.go:35:2: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules:
	google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013 (/home/jrick/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status)
	google.golang.org/genproto/googleapis/rpc v0.0.0-20240604185151-ef581f913117 (/home/jrick/go/pkg/mod/google.golang.org/genproto/googleapis/[email protected]/status)

Updating to a more recent google.golang.org/genproto fixes the workspace
build.
@jrick jrick merged commit 21afb9d into decred:master Jan 13, 2025
2 checks passed
@jrick jrick deleted the wtf branch January 13, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants