Request more p2p addrs after peer checks #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Jan 23, 2024
If the height or required services is deemed insufficient after the connection handshake, do not request more addresses right away, waiting for its response before killing the TCP connection. This stops ConnectOutbound from returning early with error while the TCP connection is still active, and causing the SPV syncer to begin connecting to more remote peers. While the SPV syncer remains limited to 8 total outbound managed peers, the total count of TCP connections can easily exceed this, and has been observed to max out the circuit limit on Tor proxies. Although this appears to move the address requesting to the foreground of ConnectOutbound, it only writes the getaddr message. addr message replies are handled internally by the RemotePeer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the height or required services is deemed insufficient after the connection handshake, do not request more addresses right away, waiting for its response before killing the TCP connection. This stops ConnectOutbound from returning early with error while the TCP connection is still active, and causing the SPV syncer to begin connecting to more remote peers. While the SPV syncer remains limited to 8 total outbound managed peers, the total count of TCP connections can easily exceed this, and has been observed to max out the circuit limit on Tor proxies.