multi: Refactor wallet.NetworkBackend. #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
reviewed
Dec 22, 2023
matheusd
force-pushed
the
rpc-network-backend
branch
from
2956858 to
a918500
Compare
matheusd
force-pushed
the
rpc-network-backend
branch
from
a918500 to
95f7cfe
Compare
|
@matheusd you still have the commit message from the second commit in the squashed commit :p |
This unifies the wallet's Peer and NetworkBackend interfaces into a single interface, given the SPV peer syncer now fulfills both roles. In order to complete the refactor, the following changes are made: - The funcs that were in Peer are moved to NetworkBackend. - The missing funcs are added to chain.Syncer, forwading the calls to the dcrd client connection. - chain.Syncer assigns itself as NetworkBackend to the wallet, instead of assigning the client connection. - deployments package is modified to take a more limited interface (Querier) instead of the syncer var directly, to avoid circular pkg dependencies. - The live ticket querier (in tickets.go) is modified to take a more limited interface instead of the syncer var directly, to avoid circular pkg dependencies. - Call sites that type selected on *dcrd.RPC are modified to type select on *chain.Syncer. - A Synced() function is added to the NetworkBackend interface so that the JSON-RPC server can more accurately query for synced status from the underlying syncer. In the future, the dependency on concrete type checking could be further reduced on other call sites by using the same technique that was employed in this commit for the deployments package.
matheusd
force-pushed
the
rpc-network-backend
branch
from
95f7cfe to
6cde2cc
Compare
|
grrrr, sorry for that. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the wallet's Peer and NetworkBackend interfaces into a single interface, given the SPV peer syncer now fulfills both roles.
In order to complete the refactor, the following changes are made:
In the future, the dependency on concrete type checking could be further reduced on other call sites by using the same technique that was employed in this commit for the deployments package.
Close #2317.