chain: Avoid early getHeaders on sidechains #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check for the presence of the parent block on a known sidechain prior to re-requesting all headers on announced blocks during RPC chain sync Prior to this commit, the parent block was checked for presence only on the main chain, which could cause getHeaders to be repeatedly executed on reorgs of size greater than one. This was mostly an issue for automated tests that generate large reorgs.
jrick
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for the presence of the parent block on a known sidechain prior to re-requesting all headers on announced blocks during RPC chain sync
Prior to this commit, the parent block was checked for presence only on the main chain, which could cause getHeaders to be repeatedly executed on reorgs of size greater than one.
This was mostly an issue for automated tests that generate large reorgs.