dex/{networks,testing}: Add simnet USDC #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Why do we need separate contract TestToken and contract TestUSDC? Can't they be the same contract on simnet?
There was a problem hiding this comment.
You're right, it's not necessary. I added a parameter to the TestToken contract so that the decimals can be 6 like the actual contract.
buck54321
reviewed
Jan 24, 2024
| constructor() { | ||
| _name = "TestToken"; | ||
| _symbol = "TST"; | ||
| constructor(bool usdc) { |
There was a problem hiding this comment.
Why not constructor(uint8 decimals)?
There was a problem hiding this comment.
Just to have the correct _name and _symbol.. there's no point though.
True, if no one needs it I'll just remove it. |
|
I'd really like to get rid of the dextt token. We can just call it usdc.polygon. It's existence causes a lot of headaches. |
|
@buck54321 Got rid of it. |
This adds the usdc.eth and usdc.polygon assets to simnet and gets rid of dextt.
buck54321
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the usdc.eth and usdc.polygon assets to simnet and gets rid of dextt.