-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dex/testing: Update walletpair #2639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
It seems 127.0.0.4
& 127.0.0.5
are unassignable on my end. I'm lazy to dig why but any reason why we are not using 127.0.0.1
?
2023-12-27 00:37:37.521 [ERR] DEXC: Error starting rpc server: connect failure: can't listen on 127.0.0.5:5763. rpc server quitting: listen tcp 127.0.0.5:5763: bind: can't assign requested address
@ukane-philemon Are you using mac? https://superuser.com/questions/458875/how-do-you-get-loopback-addresses-other-than-127-0-0-1-to-work-on-os-x I'm not sure why we use them either though. I think we could just 127.0.0.1 and different ports. |
Yes. I always have to specify webaddr when running dexc from cli. |
Thanks for the link. I never needed to use any local address other than 127.0.0.1 and running a script to set alias each time can be a pita. |
Please don't do this. Cookies are based on IP alone without port. I use dexc on mainnet, and this will screw up my cookies. See my the solution at #2647 (comment) for a hint for fixing this on Mac. |
Okay. Just hoping I won’t have to set aliases every time 😅. |
This adds a simnet option to the wallet pair which runs both dex clients on simnet and puts the appdata in a separate folder. Also, both of the dex clients now run an rpc server, and dexcctl scripts for each client are added to the harness-ctl folder.
074bd82
to
6684821
Compare
I've updated the IPs on the simnet wallet pair as well. |
Unable to use dexc1ctl:
Can you add that we can use the |
This adds a simnet option to the wallet pair which runs both dex clients on simnet and puts the appdata in a separate folder. Also, both of the dex clients now run an rpc server, and dexcctl scripts for each client are added to the harness-ctl folder.