Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex/testing: Update walletpair #2639

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

martonp
Copy link
Collaborator

@martonp martonp commented Dec 26, 2023

This adds a simnet option to the wallet pair which runs both dex clients on simnet and puts the appdata in a separate folder. Also, both of the dex clients now run an rpc server, and dexcctl scripts for each client are added to the harness-ctl folder.

Copy link
Contributor

@ukane-philemon ukane-philemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It seems 127.0.0.4 & 127.0.0.5 are unassignable on my end. I'm lazy to dig why but any reason why we are not using 127.0.0.1?

2023-12-27 00:37:37.521 [ERR] DEXC: Error starting rpc server: connect failure: can't listen on 127.0.0.5:5763. rpc server quitting: listen tcp 127.0.0.5:5763: bind: can't assign requested address

@martonp
Copy link
Collaborator Author

martonp commented Dec 27, 2023

@ukane-philemon Are you using mac? https://superuser.com/questions/458875/how-do-you-get-loopback-addresses-other-than-127-0-0-1-to-work-on-os-x

I'm not sure why we use them either though. I think we could just 127.0.0.1 and different ports.

@ukane-philemon
Copy link
Contributor

@ukane-philemon Are you using mac? https://superuser.com/questions/458875/how-do-you-get-loopback-addresses-other-than-127-0-0-1-to-work-on-os-x

I'm not sure why we use them either though. I think we could just 127.0.0.1 and different ports.

Yes. I always have to specify webaddr when running dexc from cli.

@ukane-philemon
Copy link
Contributor

Thanks for the link. I never needed to use any local address other than 127.0.0.1 and running a script to set alias each time can be a pita.

@buck54321
Copy link
Member

@ukane-philemon Are you using mac? https://superuser.com/questions/458875/how-do-you-get-loopback-addresses-other-than-127-0-0-1-to-work-on-os-x

I'm not sure why we use them either though. I think we could just 127.0.0.1 and different ports.

Please don't do this. Cookies are based on IP alone without port. I use dexc on mainnet, and this will screw up my cookies.

See my the solution at #2647 (comment) for a hint for fixing this on Mac.

@ukane-philemon
Copy link
Contributor

See my the solution at #2647 (comment) for a hint for fixing this on Mac.

Okay. Just hoping I won’t have to set aliases every time 😅.

This adds a simnet option to the wallet pair which runs both dex clients
on simnet and puts the appdata in a separate folder. Also, both of the
dex clients now run an rpc server, and dexcctl scripts for each client
are added to the harness-ctl folder.
@martonp
Copy link
Collaborator Author

martonp commented Dec 29, 2023

Please don't do this. Cookies are based on IP alone without port. I use dexc on mainnet, and this will screw up my cookies.

I've updated the IPs on the simnet wallet pair as well.

@JoeGruffins
Copy link
Member

JoeGruffins commented Jan 2, 2024

Unable to use dexc1ctl:

$ ./dexc1ctl help
unable to send request: Post "https://127.0.0.4:5761": tls: failed to verify certificate: x509: certificate is valid for 127.0.0.1, ::1, 192.168.1.62, 127.0.0.2, 127.0.0.3, not 127.0.0.4

Can you add that we can use the --simnet flag to the README. Or am I supposed to run it SIMNET=1 ./walletpair.sh?

@buck54321 buck54321 merged commit 9e6a621 into decred:master Jan 11, 2024
5 checks passed
@martonp martonp deleted the updateWalletpair branch January 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants