Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcr: work around ticket purchase bug #2607

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

buck54321
Copy link
Member

@buck54321 buck54321 commented Nov 15, 2023

Implement a ticket queue to work around a known bug where fewer tickets than requested are purchased without error.

Show number of queued tickets on front end.

Closes #2496

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well.

client/asset/dcr/dcr.go Show resolved Hide resolved
client/asset/dcr/dcr.go Outdated Show resolved Hide resolved
client/asset/dcr/dcr.go Outdated Show resolved Hide resolved
client/asset/dcr/dcr.go Outdated Show resolved Hide resolved
client/asset/dcr/dcr.go Show resolved Hide resolved
client/asset/dcr/dcr.go Show resolved Hide resolved
Copy link
Collaborator

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely. I think the UI would be a bit nicer with immediate failure if the balance is too low though.

client/asset/dcr/dcr.go Outdated Show resolved Hide resolved
client/asset/dcr/dcr.go Show resolved Hide resolved
client/asset/dcr/dcr.go Outdated Show resolved Hide resolved
@JoeGruffins
Copy link
Member

This closes #2496 ?

@buck54321 buck54321 merged commit 71de25d into decred:master Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

staking,ui: fix ticket purchasing for n > 1
4 participants