client/btc: Improve ReturnCoins processing #2425
Closed
+93
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Jul 5, 2023
JoeGruffins
reviewed
Jul 5, 2023
The same exactly |
chappjc
reviewed
Jul 10, 2023
buck54321
requested changes
Oct 3, 2023
| // return 'true' but do nothing so a warning is issued below. | ||
| // | ||
| // See Also: btc_test.go: RawRequest case: methodLockUnspent | ||
| func (wc *rpcClient) lockAllUnspent(unlock bool) error { |
There was a problem hiding this comment.
Why accept an unlock argument at all? Also, why name the method lock when it unlocks?
| wc.log.Warn("attempting to lock all unspent outputs 'lockunspent false'") | ||
| } | ||
| var rpcReturn bool | ||
| err := wc.call(methodLockUnspent, anylist{unlock}, &rpcReturn) |
There was a problem hiding this comment.
Verified that this works for Dogecoin and Firo. Doesn't work for Zcash, but doesn't matter because #2553.
|
Reopen if it's important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve processing for ReturnCoins.
original pr