blockchain: Remove main chain index from db. #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_remove_mainchain_index
branch
from
8c204dd to
d7e0713
Compare
alexlyp
approved these changes
Jul 9, 2018
This removes the main chain index from the database as well as all code related to reading and writing it (other than those in the upgrade paths) since it is no longer used and bumps the database version since it is not possible to downgrade after the main chain index has been removed.
davecgh
force-pushed
the
blockchain_remove_mainchain_index
branch
from
d7e0713 to
3ca9def
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: It is not possible to downgrade after running this PR. If you plan to test it, please make a copy of your data directory first.
This PR requires #1332.
This removes the main chain index from the database as well as all code related to reading and writing it (other than those in the upgrade paths) since it is no longer used and bumps the database version since it is not possible to downgrade after the main chain index has been removed.
Testing Notes
As of this PR, the expected behavior is that there is a single migration that takes a couple of seconds to complete after which it will no longer be possible to downgrade.
As the warning above notes, if you try to run an older software version after this migration has completed, you will get an error message similar to
Unable to start server on [:9108]: the current blockchain database is no longer compatible with this version of the software (4 > 3).This is work towards #1145.