feat: Add on click prop to banner (#224)

decentraland · Jan 22, 2025 · 29ff52c · 29ff52c
1 parent 37a11d9
commit 29ff52c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/components/Banner/Banner.tsx b/src/components/Banner/Banner.tsx
@@ -32,6 +32,7 @@ const convertAlignmentToFlex = (alignment: Property.TextAlign) => {
 export const Banner: React.FC<BannerProps> = (props: BannerProps) => {
   const {
     isLoading,
+    onClick,
     fields,
     assets,
     locale = ContentfulLocale.enUS,
@@ -52,7 +53,7 @@ export const Banner: React.FC<BannerProps> = (props: BannerProps) => {
     return null
   }
 
-  // Build the parameteres based on the size of the screen
+  // Build the parameters based on the size of the screen
   const bannerBackgroundImage = getAssetUrl(
     assets,
     ContentfulLocale.enUS,
@@ -99,6 +100,7 @@ export const Banner: React.FC<BannerProps> = (props: BannerProps) => {
         fields.buttonsText?.[locale] ? (
           <ButtonContainer justifyContent={buttonAlignment}>
             <Button
+              onClick={onClick}
               href={fields.buttonLink[ContentfulLocale.enUS]}
               variant="contained"
               disableElevation

diff --git a/src/components/Banner/Banner.types.ts b/src/components/Banner/Banner.types.ts
@@ -4,8 +4,9 @@ type BannerProps = {
   fields: BannerFields | null
   assets: Record<string, ContentfulAsset>
   isLoading: boolean
-  locale?: ContentfulLocale
   error: string | null
+  onClick?: React.MouseEventHandler<HTMLButtonElement>
+  locale?: ContentfulLocale
 }
 
 type LowercasedAlignment = "left" | "center" | "right"