feat: notifications toggle #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braianj
reviewed
Dec 1, 2023
Comment on lines
+13
to
+17
| const i18N = { | ||
| en: { description: 'You just sold ', title: 'Item Sold' }, | ||
| es: { description: 'Vendiste ', title: 'Item vendido' }, | ||
| zh: { description: '你剛剛賣了 ', title: '已售商品' } | ||
| } |
There was a problem hiding this comment.
Maybe we can put this into a global translation file
Suggested change
| const i18N = { | |
| en: { description: 'You just sold ', title: 'Item Sold' }, | |
| es: { description: 'Vendiste ', title: 'Item vendido' }, | |
| zh: { description: '你剛剛賣了 ', title: '已售商品' } | |
| } | |
| const i18N = { | |
| ItemSoldNotification: { | |
| en: { description: 'You just sold ', title: 'Item Sold' }, | |
| es: { description: 'Vendiste ', title: 'Item vendido' }, | |
| zh: { description: '你剛剛賣了 ', title: '已售商品' } | |
| } | |
| } |
There was a problem hiding this comment.
For this particular case, I prefer to keep each i18N in each component file. I find it more comfortable and cleaner
| </div> | ||
| )} | ||
| {!userNotifications.length && ( | ||
| <div className="dcl notifications-feed__emptyview"> |
There was a problem hiding this comment.
if you use the before suggestion change from emptyview to empty-view then this should be
Suggested change
| <div className="dcl notifications-feed__emptyview"> | |
| <div className="dcl notifications-feed__empty-view"> |
There was a problem hiding this comment.
kept it all as notifications-feed__emptyview-*
|
🎉 This PR is included in version 4.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.