Move export prometheus_text_format:escape_label_value outside of TEST def #158
Conversation
| @@ -76,6 +77,15 @@ format(Registry) -> | |||
| ok = file:close(Fd), | |||
| Str. | |||
|
|
|||
| -spec escape_label_value(binary() | iolist() | undefined) -> binary(). | |||
There was a problem hiding this comment.
Existing type-spec is a bit strange, this function does not return binary() for input undefined
There was a problem hiding this comment.
is it possible to fix in this PR?
There was a problem hiding this comment.
Looks like my local workspace didn't have GPG signatures setup correctly, so I'll create a new PR anyways with the signed commits. I'll update the spec to the following to more accurately represent the function.
-spec escape_label_value(binary() | iolist()) -> binary()
; (undefined) -> no_return().
There was a problem hiding this comment.
Nvm no need for new PR, figured out how to retroactively sign commits :) Otherwise, the spec has been updated, please let me know if you find it more appropriate. Thanks in advance
aaron-seo
force-pushed
the
export_escape_label_value
branch
2 times, most recently
from
c2bc355 to
e3f2c8d
Compare
aaron-seo
force-pushed
the
export_escape_label_value
branch
from
38b00b8 to
f28837a
Compare
|
@ikvmw you may have to explicitly approve workflow runs for this PR as it is from/by a first-time contributor |
|
May need to be merged manually even after approval, due to the job |
|
Just bumping this for merge, if there are other tasks needed for the process, please feel free to let me know, thanks @deadtrickster @ikvmw |
prometheus_text_format:escape_label_valueis a useful helper function that users can benefit from using without having to duplicate the function in their code.Namely, it can be used to escape prometheus core metric label values -- based on issue rabbitmq/rabbitmq-server#9648 and relevant PR/review from rabbitmq/rabbitmq-server#9656