Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editions to bottles #211

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Add editions to bottles #211

merged 5 commits into from
Aug 7, 2024

Conversation

dcramer
Copy link
Owner

@dcramer dcramer commented Aug 6, 2024

Conform alias name with bottle.fullName going forward, and include edition in it.

This cleans up some incorrect schema usage as well in the bottle entry points, and compacts the BottleSchema, with a likely pattern we'll apply elsewhere.

Refs GH-210

Conform alias name with bottle.fullName going forward, and include edition in it.
@dcramer dcramer enabled auto-merge (squash) August 6, 2024 23:44
Copy link

codecov bot commented Aug 6, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 405 tests with 1 failed, 404 passed and 0 skipped.

View the full list of failed tests

src/trpc/routes/bottleUpdate.test.ts

  • Class name: src/trpc/routes/bottleUpdate.test.ts
    Test name: clears category

    AssertionError: expected { id: 1, …(23) } to deeply equal { id: 1, …(23) }
    ❯ .../trpc/routes/bottleUpdate.test.ts:99:49

@dcramer dcramer merged commit ac2bf43 into main Aug 7, 2024
4 checks passed
@dcramer dcramer deleted the feat/add-edition branch August 7, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant