Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pwacompat to auto insert meta/link tags #114

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

getsetbro
Copy link
Contributor

A browser will show your custom splash screen so long as you meet the following requirements in your web app manifest:

  • The name property is set to the name of your PWA.
  • The background_color property is set to a valid CSS color value.
  • The icons array specifies an icon that is at least 512px by 512px.
  • The icon exists and is a PNG.

So I uncommented the 512 png in the manifest file.

Then I added a script link to the PWACompat - "the Web App Manifest for all browsers". Much like google fonts it determines your device/browser and makes the relevant changes. https://developer.chrome.com/blog/pwacompat

@@ -261,6 +262,11 @@ function Document({
defer
></script>
)}
<script
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth bundling this at all? ill have to dig into it more to understand

is this just compat ala does it only add browser support?

@dcramer dcramer enabled auto-merge (squash) December 22, 2023 19:34
@dcramer dcramer merged commit d4e586b into dcramer:main Dec 22, 2023
1 check passed
@getsetbro
Copy link
Contributor Author

getsetbro commented Dec 22, 2023 via email

@getsetbro getsetbro deleted the feature/pwa-splash-image branch January 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants