Fix wrong condition #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition of the `FindBox` inner loop is wrong and allows `x` go beyond `itemsToPack[y].Quantity` iterations as soon as `Quantity > 1`. As a result, the analyzed box may be one of another box "type", and will be analyzed again later by following iterations of outer loop. The empty item added in `Initialize` serves no purpose anymore since it just prevented OutOfRange exceptions caused by the wrong check discussed above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition of the
FindBoxinner loop is wrong and allowsxgo beyonditemsToPack[y].Quantityiterations as soon asQuantity > 1. As a result, the analyzed box may be one of another box "type", and will be analyzed again later by following iterations of outer loop.The empty item added in
Initializeserves no purpose anymore since it just prevented OutOfRange exceptions caused by the wrong check discussed above.