Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scrollbar] Add theming for rounded corners #2108

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

J0hannes101
Copy link
Contributor

This PR adds a new rounded-corners option in the scrollbar{ } category for theming.

Example:

scrollbar {
    padding: 0px 0px 0px 10px;  
    rounded-corners: true;
    handle-width: 6px ;
    handle-color: red;
}

@DaveDavenport
Copy link
Collaborator

Thanks for the patch.
I had on my todo list, to turn the handle as a subwidget, so it would inherit all theme theming options of a normal 'widget' (including the rounded corners).

Maybe this solution is easier and sufficient.
Would ' rounded-corners' better be 'handle-rounded-corners'? so it matches with the other properties?

@J0hannes101
Copy link
Contributor Author

So i should rename it handle-rounded-corners for now?

@DaveDavenport
Copy link
Collaborator

It would make it more clear its on the handle, and not the widget itself (that is 'border-radius' where you can specify it for each corner)

@J0hannes101
Copy link
Contributor Author

@DaveDavenport is everything good for merging, or did i miss something?

@DaveDavenport
Copy link
Collaborator

No, just have been very busy.

@DaveDavenport DaveDavenport merged commit 56fd08e into davatorium:next Mar 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants