Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP-999 Compilation error in cpp-driver-2.16.2 when using C++98 standard #569

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

absurdfarce
Copy link
Collaborator

Remove C++11 usage in favor of a struct constructor to be explicit about the zero value init

@absurdfarce
Copy link
Collaborator Author

Don't overthink this; let's solve this the easy way via a base constructor for the snapshot struct. Makes sense for that as a default anyway and you avoid any concerns about default val initialization.

@absurdfarce
Copy link
Collaborator Author

Things to look into/fix after review with @lukasz-antoniak:

  • Add the explicit call to zero arg constructor for zero_snapshot_ (just to be explicit)
  • Can we create a singleton zero_snapshot_ rather than a per-histogram val?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant