Drop the --export-max-records flag (#136)

datastax · Apr 10, 2023 · 2208081 · 2208081
1 parent a185ed8
commit 2208081
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 19 deletions.
diff --git a/backfill-cli/src/main/java/com/datastax/oss/cdc/backfill/admin/BackfillCommand.java b/backfill-cli/src/main/java/com/datastax/oss/cdc/backfill/admin/BackfillCommand.java
@@ -110,14 +110,6 @@ public List<ParameterDescriptor> parameters() {
                         .type(ParameterType.STRING)
                         .names(Arrays.asList("--export-consistency"))
                         .build());
-        parameters.add(
-                ParameterDescriptor.builder()
-                        .description(
-                                "The maximum number of records to export from the table. Must be a positive number or -1. "
-                                        + "The default is -1 (export the entire table).")
-                        .type(ParameterType.INTEGER)
-                        .names(Arrays.asList("--export-max-records"))
-                        .build());
         parameters.add(
                 ParameterDescriptor.builder()
                         .description(

diff --git a/backfill-cli/src/main/java/com/datastax/oss/cdc/backfill/exporter/ExportSettings.java b/backfill-cli/src/main/java/com/datastax/oss/cdc/backfill/exporter/ExportSettings.java
@@ -138,15 +138,6 @@ public char[] getPassword() {
             defaultValue = "LOCAL_QUORUM")
     public DefaultConsistencyLevel consistencyLevel = DefaultConsistencyLevel.LOCAL_QUORUM;
 
-    @Option(
-            names = "--export-max-records",
-            paramLabel = "NUM",
-            description =
-                    "The maximum number of records to export from the table. Must be a positive number or -1. "
-                            + "The default is -1 (export the entire table).",
-            defaultValue = "-1")
-    public int maxRecords = -1;
-
     @Option(
             names = "--export-max-concurrent-files",
             paramLabel = "NUM|AUTO",

diff --git a/backfill-cli/src/main/java/com/datastax/oss/cdc/backfill/exporter/TableExporter.java b/backfill-cli/src/main/java/com/datastax/oss/cdc/backfill/exporter/TableExporter.java
@@ -192,8 +192,6 @@ private List<String> createExportArgs(String operationId) {
         }
         args.add("-url");
         args.add(String.valueOf(tableDataDir));
-        args.add("-maxRecords");
-        args.add(String.valueOf(settings.exportSettings.maxRecords));
         args.add("-maxConcurrentFiles");
         args.add(settings.exportSettings.maxConcurrentFiles);
         args.add("-maxConcurrentQueries");