Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade constant column feature to support remove & replace column and also resolve any bugs #268

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

pravinbhat
Copy link
Collaborator

@pravinbhat pravinbhat commented Jul 9, 2024

What this PR does:
Upgrades the constant column feature to support remove & replace of columns from origin to target and also resolve any bugs

Which issue(s) this PR fixes:
Fixes #267

Checklist:

  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

Copy link
Collaborator

@msmygit msmygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures here (though values looks correct to me)

@pravinbhat
Copy link
Collaborator Author

CI failures here (though values looks correct to me)

Fixed!

@pravinbhat pravinbhat added bug Something isn't working enhancement New feature or request labels Jul 9, 2024
@@ -1,4 +1,9 @@
# Release Notes
## [4.2.0] - 2024-07-09
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we're bumping to 4.2 now. Does this have any backward incompatibility changes and hence the need to bump the minor?

Copy link
Collaborator Author

@pravinbhat pravinbhat Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, its fully backward compatible. As this version adds an important feature (customer ask), we are bumping the minor version. We follow semantic versioning.

@msmygit msmygit enabled auto-merge (squash) July 10, 2024 05:23
Copy link
Collaborator

@msmygit msmygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@msmygit msmygit merged commit 0f12303 into main Jul 10, 2024
7 checks passed
@msmygit msmygit deleted the issue/constant-column-bug branch July 10, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants