-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade constant column feature to support remove & replace column and also resolve any bugs #268
Conversation
…olumns addeds as part of constant column. Also fixed the associated SIT tests to test this feature correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failures here (though values looks correct to me)
Fixed! |
@@ -1,4 +1,9 @@ | |||
# Release Notes | |||
## [4.2.0] - 2024-07-09 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we're bumping to 4.2
now. Does this have any backward incompatibility changes and hence the need to bump the minor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, its fully backward compatible. As this version adds an important feature (customer ask), we are bumping the minor version. We follow semantic versioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏼
What this PR does:
Upgrades the
constant column
feature to supportremove
&replace
of columns fromorigin
totarget
and also resolve any bugsWhich issue(s) this PR fixes:
Fixes #267
Checklist: