New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes test.sh more robust #237

Merged

msmygit merged 1 commit into datastax:main from arvy:makes-test-bash-script-more-robust

Jan 4, 2024

Contributor

arvy commented Dec 18, 2023

What this PR does:

Makes test bash script more robust:

uses find+mv to move files, which makes it best-effort (no failure when no source files found)
wraps commands that involve redirects in double-quotes and executes via bash -c


          Makes test.sh more robust

00199f6

arvy requested a review from a team as a code owner

December 18, 2023 22:49

arvy requested review from jeromatron, pravinbhat, msmygit and faizalrub-datastax

December 18, 2023 22:49

msmygit approved these changes

View reviewed changes

faizalrub-datastax approved these changes

View reviewed changes

msmygit merged commit ce7fdef into datastax:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

msmygit msmygit approved these changes

faizalrub-datastax faizalrub-datastax approved these changes

jeromatron Awaiting requested review from jeromatron jeromatron is a code owner automatically assigned from datastax/cdm-core

pravinbhat Awaiting requested review from pravinbhat pravinbhat is a code owner automatically assigned from datastax/cdm-core

Labels

None yet